TsukiokaKogane commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3366987143


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##########
@@ -243,6 +253,13 @@ private LogicalPlan makeOlapScan(TableIf table, 
UnboundRelation unboundRelation,
                     CollectionUtils.isEmpty(partIds) ? ((OlapTable) 
table).getPartitionIds() : partIds, indexId,
                     preAggStatus, CollectionUtils.isEmpty(partIds) ? 
ImmutableList.of() : partIds,
                     unboundRelation.getHints(), 
unboundRelation.getTableSample(), ImmutableList.of());
+            } else if (isChangeRead(unboundRelation)) {
+                OlapTable olapTable = (OlapTable) table;
+                RowBinlogTableWrapper wrapper = new 
RowBinlogTableWrapper(olapTable);

Review Comment:
   之后binlog会改成物化index OlapTableWrapper/RowBinlogTableWrapper那个时候应该就没了



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RowBinlogTableWrapper.java:
##########
@@ -33,6 +36,14 @@ public RowBinlogTableWrapper(OlapTable originTable) {
         this.setBaseIndexId(rowBinlogMeta.getIndexId());
     }
 
+    public RowBinlogTableWrapper(OlapTable originTable, OlapTableStreamWrapper 
parent) {
+        super(originTable, originTable.getName(), 
originTable.getRowBinlogMeta().getSchema(), KeysType.DUP_KEYS);

Review Comment:
   之后binlog会改成物化物化index RowBinlogTableWrapper那个时候应该就没课 这块到时候应需要重新对接 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to