github-actions[bot] commented on code in PR #64164: URL: https://github.com/apache/doris/pull/64164#discussion_r3369154703
########## be/src/util/debug/leak_annotations.h: ########## @@ -22,7 +22,7 @@ #define ANNOTATE_LEAKING_OBJECT_PTR(p) #if defined(__has_feature) -#if __has_feature(address_sanitizer) +#if __has_feature(address_sanitizer) || __has_feature(leak_sanitizer) Review Comment: This still does not enable `ANNOTATE_LEAKING_OBJECT_PTR` for GCC sanitizer builds. Doris' BE CMake sets `-DADDRESS_SANITIZER` for ASAN/ASAN_UT and `-DLEAK_SANITIZER` for LSAN, but GCC does not define `__has_feature`, so this macro remains the empty definition above. After `phdr_cache.cpp` switches to this helper, GCC ASAN no longer calls `__lsan_ignore_object(new_phdr_cache)`, and GCC LSAN also will not annotate the intentionally leaked PHDR cache. Please make this helper recognize Doris' `ADDRESS_SANITIZER`/`LEAK_SANITIZER` definitions as well as Clang's `__has_feature(...)` path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
