github-actions[bot] commented on code in PR #64196:
URL: https://github.com/apache/doris/pull/64196#discussion_r3371145310
##########
fe/be-java-extensions/java-common/pom.xml:
##########
@@ -100,11 +100,6 @@ under the License.
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
- <dependency>
Review Comment:
This removal is a runtime compatibility break for existing Java UDFs.
`BaseExecutor` creates the UDF jar classloader with
`getClass().getClassLoader()` as the parent, so user UDF jars can currently
resolve dependencies from the BE Java extension classpath. A deployed UDF
compiled with `org.apache.commons.lang.StringUtils` and not shading
`commons-lang` will now fail at runtime with `NoClassDefFoundError`, even
though the in-repo regression UDF was migrated to lang3. Please keep packaging
`commons-lang` 2.x for compatibility, or add an explicit
compatibility/deprecation path that does not break existing UDF jars on upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
