heguanhui opened a new issue, #64227:
URL: https://github.com/apache/doris/issues/64227

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Version
   
   master
   
   ### What's Wrong?
   
   When building BE UT with TSAN, the linker reports an undefined symbol error:
   
   ```
   ld.lld: error: undefined symbol: doris::io::FileBlockCell* 
doris::io::BlockFileCache::get_cell<std::lock_guard<std::mutex>>(doris::io::UInt128Wrapper
 const&, unsigned long, T&)
   >>> referenced by block_file_cache_test.cpp:2976 
(./be/ut_build_TSAN/./be/test/io/cache/block_file_cache_test.cpp:2976)
   >>>               
test/CMakeFiles/doris_be_test.dir/io/cache/block_file_cache_test.cpp.o:(doris::io::BlockFileCacheTest_late_holder_remove_skips_replaced_cache_cell_Test::TestBody())
   >>> referenced by block_file_cache_test.cpp:2989 
(./be/ut_build_TSAN/./be/test/io/cache/block_file_cache_test.cpp:2989)
   >>>               
test/CMakeFiles/doris_be_test.dir/io/cache/block_file_cache_test.cpp.o:(doris::io::BlockFileCacheTest_late_holder_remove_skips_replaced_cache_cell_Test::TestBody())
   clang++: error: linker command failed with exit code 1 (use -v to see 
invocation)
   ninja: build stopped: subcommand failed.
   ```
   
   ### What You Expected?
   
   BE UT should build and link successfully with TSAN enabled.
   
   ### How to Reproduce?
   
   1. Build BE UT with TSAN: `bash build.sh --be --ut --tsan`
   2. Linker fails with undefined symbol for 
`BlockFileCache::get_cell<std::lock_guard<std::mutex>>`
   
   ### Root Cause
   
   `BlockFileCache::get_cell` is a template function with `requires IsXLock<T>` 
constraint, defined in `block_file_cache.cpp`. It lacks explicit template 
instantiation for `std::lock_guard<std::mutex>`. In non-TSAN builds, the 
compiler may inline the template, masking the issue. TSAN builds disable 
inlining (instrumentation requires intercepting each function call), exposing 
the missing symbol.
   
   The same pattern already exists for the `remove` template function at 
`block_file_cache.cpp:2515`:
   ```cpp
   template void BlockFileCache::remove(FileBlockSPtr file_block,
                                        std::lock_guard<std::mutex>& cache_lock,
                                        std::lock_guard<std::mutex>& 
block_lock, bool sync);
   ```
   
   And for `LRUQueue` templates in `file_cache_common.cpp:149-150`:
   ```cpp
   template size_t LRUQueue::get_capacity(std::lock_guard<std::mutex>& 
cache_lock) const;
   template void LRUQueue::remove(Iterator queue_it, 
std::lock_guard<std::mutex>& cache_lock);
   ```
   
   `get_cell` is simply missing the same explicit instantiation.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to