github-actions[bot] commented on code in PR #64208:
URL: https://github.com/apache/doris/pull/64208#discussion_r3377434776
##########
fe/pom.xml:
##########
@@ -293,7 +294,7 @@ under the License.
<metrics-core.version>4.0.2</metrics-core.version>
<!--Netty 4.1.94 is not compatible with arrow flight.-->
<!--Need to ensure that the version is the same as in
arrow/java/pom.xml or compatible with it.-->
- <netty-all.version>4.1.132.Final</netty-all.version>
Review Comment:
This globally moves the imported Netty BOM to 4.2.x, but `fe-core` still
depends on unshaded `io.grpc:grpc-netty:1.65.1` (`fe/fe-core/pom.xml`). With
this PR, `mvn -pl fe-core -DskipTests dependency:tree
-Dincludes=io.netty:netty-common,io.netty:netty-buffer,io.netty:netty-handler,io.netty:netty-transport,io.netty:netty-codec-http2,io.grpc:grpc-netty,io.netty:netty-all`
resolves `grpc-netty:1.65.1` alongside Netty `4.2.15.Final`. gRPC's Netty
troubleshooting table documents `grpc-netty` 1.60+ with Netty 4.1.x
combinations and warns that dependency-management overrides can cause runtime
Netty/ALPN/classpath failures; 4.2.x is not listed as a supported combination.
Please either keep the FE Netty BOM on a 4.1.x version compatible with the
current `grpc-netty`, update the gRPC transport/version to one that explicitly
supports Netty 4.2.x, or switch this unshaded path to `grpc-netty-shaded` so
the transport owns its Netty version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
