jacktengg opened a new pull request, #64285:
URL: https://github.com/apache/doris/pull/64285
Problem Summary:
Several FE session variables were serialized into TQueryOptions in
SessionVariable.toThrift() and shipped to BE on every query, but BE never reads
the corresponding fields. This is dead RPC payload and dead FE configuration
surface.
After auditing every field written by SessionVariable.toThrift() against all
BE/cloud usage, the following 7 TQueryOptions fields are set by FE but never
consumed by BE:
- enable_common_expr_pushdown
- enable_common_expr_pushdown_for_inverted_index (already thrift-deprecated)
- enable_phrase_query_sequential_opt
- enable_rust_lance_reader (BE selects the Lance reader by file format, not
by this option)
- shuffled_agg_ids
- resource_limit (TResourceLimit.cpu_limit)
- skip_bad_tablet
For the first five, the backing session variable is also unused anywhere
else in FE, so the variable is fully removed (field, @VarAttr, name constant,
getter/setter, fuzzy assignment and the toThrift plumbing). To preserve
compatibility with existing SET/JDBC init statements, the removed variable
names are added to VariableMgr.REMOVED_SESSION_VAR_NAMES, which makes them
silently no-op instead of raising ERR_UNKNOWN_SYSTEM_VARIABLE.
cpuResourceLimit and skipBadTablet are still used by other FE logic (user
properties / statistics, and OlapScanNode / CacheAnalyzer respectively), so
only their dead TQueryOptions plumbing is removed; the variables themselves are
kept. The thrift definitions are left untouched for BE compatibility.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
