github-actions[bot] commented on code in PR #64229:
URL: https://github.com/apache/doris/pull/64229#discussion_r3385350820
##########
be/src/storage/index/inverted/inverted_index_parser.h:
##########
@@ -82,6 +82,12 @@ const std::string INVERTED_INDEX_PARSER_PHRASE_SUPPORT_KEY =
"support_phrase";
const std::string INVERTED_INDEX_PARSER_PHRASE_SUPPORT_YES = "true";
const std::string INVERTED_INDEX_PARSER_PHRASE_SUPPORT_NO = "false";
+// token-exists Bloom Filter sub-file gate (default off). When "true", the
writer emits
+// the "tbf" sub-file recording which analyzed tokens exist in this segment's
term dict.
+const std::string INVERTED_INDEX_PARSER_TOKEN_BF_KEY = "token_bloom_filter";
Review Comment:
This new index property is not registered on the FE side.
`InvertedIndexUtil.checkInvertedIndexProperties()` has a fixed `allowedKeys`
set sourced from `InvertedIndexProperties`, and this PR does not add
`token_bloom_filter` there or validate it as a boolean. As a result, normal SQL
such as `CREATE INDEX ... PROPERTIES("token_bloom_filter"="true")` is rejected
with `Invalid inverted index property key: token_bloom_filter`, so the BE
writer gate added here is only reachable from tests that manually construct
`TabletIndexPB`. Please add the FE constant/allow-list/validation path and a
DDL or regression test that proves the property is accepted and persisted to BE
metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
