yiguolei commented on code in PR #64344:
URL: https://github.com/apache/doris/pull/64344#discussion_r3385417366
##########
be/src/core/data_type_serde/data_type_datetimev2_serde.cpp:
##########
@@ -328,7 +328,7 @@ Status
DataTypeDateTimeV2SerDe::serialize_one_cell_to_json(const IColumn& column
auto val = assert_cast<const ColumnDateTimeV2&,
TypeCheckOnRelease::DISABLE>(*ptr).get_element(
row_num);
char buf[64];
- char* pos = val.to_string(buf);
Review Comment:
1. 为什么是json，不是调用csv 相关的方法？
2. core 目录下所有的改动，需要有单测？
3. scale， decimal，datetimev1， timestamp 这些的scale都是咋处理的？
4. csv 格式，parquet，arrow ，json，text，csv， scale 问题是否存在？
5. 嵌套的时候， array 里面有一个datetimev2的时候，我们能否处理？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
