github-actions[bot] commented on code in PR #64361:
URL: https://github.com/apache/doris/pull/64361#discussion_r3386413737
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:
##########
@@ -992,6 +992,21 @@ class Suite implements GroovyInterceptable {
throw new RuntimeException("dictionary ${dictName} are not ready,
status: ${result}")
}
+ void waitForColocateGroupStable(String groupName, int timeoutSeconds = 60)
{
+ waitForColocateGroupStable(context.dbName, groupName, timeoutSeconds)
+ }
+
+ void waitForColocateGroupStable(String dbName, String groupName, int
timeoutSeconds = 60) {
+ String fullGroupName = "${dbName}.${groupName}"
Review Comment:
This shared helper does not handle Doris global colocate groups.
`colocate_with` accepts names starting with `__global__`, and `SHOW PROC
'/colocation_group'` reports those as the bare global name rather than
`db.__global__...` (see `ColocateTableIndex.GroupId.getFullGroupName`). With
the current unconditional prefixing,
`waitForColocateGroupStable("__global__...")` will time out even when the group
is stable. Please either leave global group names unprefixed here or make this
helper explicitly db-scoped.
##########
regression-test/suites/correctness_p0/test_colocate_join_of_column_order.groovy:
##########
@@ -68,6 +68,7 @@ suite("test_colocate_join_of_column_order") {
sql("select * from test_colocate_join_of_column_order_t1 a join
test_colocate_join_of_column_order_t2 b on a.k1=b.k2 and a.v=b.v;")
notContains "COLOCATE"
}
+ waitForColocateGroupStable("group_column_order")
Review Comment:
This wait is after the four negative `notContains "COLOCATE"` assertions
above, so those checks can still pass for the same unstable-group reason this
PR is fixing. When the group is unstable, Nereids skips colocate join
regardless of the join condition, which means these negative cases do not
actually verify the column-order logic. Please move this wait to before the
first `explain` after the inserts/planner setup so both the negative and
positive assertions run with a stable colocate group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
