nsivarajan commented on code in PR #60921:
URL: https://github.com/apache/doris/pull/60921#discussion_r3389415232
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/meta/MetaService.java:
##########
@@ -163,8 +163,7 @@ public Object put(HttpServletRequest request,
HttpServletResponse response) thro
clientHost, clientPort, machine, portStr);
clientHost = Strings.isNullOrEmpty(clientHost) ? machine : clientHost;
- String url = "http://"; +
NetUtils.getHostPortInAccessibleFormat(clientHost, Integer.valueOf(portStr))
- + "/image?version=" + versionStr;
+ String url = HttpURLUtil.buildInternalFeUrl(clientHost, "/image",
"version=" + versionStr);
Review Comment:
All FEs in a Doris cluster are expected to share the same port
configuration, so in practice both approaches yield identical results. However,
the scenario you described — ports differing across nodes during a rolling
config change — is rare but valid. Fixed in the latest commit by using the
already-validated portStr directly with the correct scheme, preserving the
original design contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
