github-actions[bot] commented on code in PR #64378:
URL: https://github.com/apache/doris/pull/64378#discussion_r3392845893
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1431,7 +1431,7 @@ public enum IgnoreSplitType {
+ "3 表示打开一些可能导致性能回退的 Counter", "The level of query
profile, "
+ "1 means only collect Counter of MergedProfile,
2 means print detailed information,"
+ " 3 means open some Counters that may cause
performance degradation"})
- public int profileLevel = 1;
+ public int profileLevel = 2;
Review Comment:
This changes the initializer for fresh `SessionVariable` objects, but it
does not update the persisted global session default that existing clusters
load from FE metadata. On upgrade, `VariableMgr.read()` calls
`variablesToRead.readFields(in)`, and `SessionVariable.readFromJson()`
overwrites this field with the value stored in the image, which will be `1`
from older releases. New connections then use
`VariableMgr.newSessionVariable()` to clone that persisted
`defaultSessionVariable`, so upgraded clusters keep default `profile_level=1`
and do not get the behavior described by this PR. Please add a versioned
refresh/migration for this default, for example through the existing
`VariableMgr.forceUpdateVariables()` path with the required variable-version
bump and the desired handling for intentional global overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
