yiguolei commented on code in PR #63850: URL: https://github.com/apache/doris/pull/63850#discussion_r3392892502
########## be/src/storage/iterator/block_reader_utils.h: ########## @@ -0,0 +1,111 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <array> +#include <cstddef> +#include <cstdint> +#include <string> +#include <string_view> + +#include "core/block/block.h" +#include "storage/binlog.h" + +namespace doris { + +constexpr int64_t ROW_BINLOG_UNKNOWN = 3; + +constexpr int64_t STREAM_CHANGE_INSERT = 0; +constexpr int64_t STREAM_CHANGE_DELETE = 1; +constexpr int64_t STREAM_CHANGE_UPDATE_BEFORE = 2; +constexpr int64_t STREAM_CHANGE_UPDATE_AFTER = 3; + +// Build the __BEFORE__ column name for a base column. +inline std::string build_before_column_name(std::string_view name) { Review Comment: 别直接往doris 这个namespace 放，太大了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
