morrySnow commented on code in PR #63974:
URL: https://github.com/apache/doris/pull/63974#discussion_r3393229042
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/query/QueryStatsRecorder.java:
##########
@@ -170,17 +196,14 @@ static boolean shouldRecord(StatementContext ctx) {
}
/**
- * Single-pass tree walk: registers scan output slots into exprIdToScan,
- * records filterHit for WHERE conjuncts, and records queryHit for
- * GROUP BY / ORDER BY / window keys and aggregate input columns.
- * Children are visited before the current node so scans are registered
first.
- * PhysicalLazyMaterializeOlapScan is checked before PhysicalOlapScan
- * because it is a subclass; the inner scan's metadata must be used.
+ * Single-pass tree walk: registers scan slots, records filterHit for
WHERE/JOIN conditions,
+ * and queryHit for GROUP BY / ORDER BY / window keys and aggregate inputs.
*/
private static void walkPlan(Plan plan,
Review Comment:
just one question, Why not use the `plan visitor` to complete the traversal
of the `plan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
