zclllyybb opened a new pull request, #64407:
URL: https://github.com/apache/doris/pull/64407
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: `IColumn::is_nullable()` only identified physical
`ColumnNullable`, while callers also need nullable semantics for
`ColumnConst(ColumnNullable)`. The old split between semantic nullable checks
and physical nullable checks made call sites ambiguous. This change removes
`is_concrete_nullable()`, makes `ColumnConst` report nullable when its nested
data column is nullable, and migrates physical-column branches to
`is_column_nullable()` or `check_and_get_column<ColumnNullable>()`. Const
nullable join keys and row-copy paths are materialized or unwrapped explicitly
so null maps are propagated correctly.
### Release note
None
### Check List (For Author)
- Test: Unit Test / Regression test / Build / Style
- `./run-be-ut.sh --run --filter=ColumnConstTest.* -j 90`
- `./run-be-ut.sh --run
--filter=ColumnConstTest.*:RuntimeFilterWrapperTest.TestBitMap:HashJoinProbeOperatorTest.*:HashJoinBuildSinkTest.*:NLJAppendProbeDataWithNullTest.*:VIcebergDeleteSinkTest.*:IcebergDeleteFileReaderHelperTest.*
-j 90`
- `./build.sh --be --fe`
- `PATH=/mnt/disk6/common/ldb_toolchain_toucan/bin:$PATH
build-support/check-format.sh`
- `./run-regression-test.sh --run -f
regression-test/suites/correctness_p0/test_runtime_filter_outer_join_nullable_side.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/correctness_p0/test_null_equal.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/correctness_p0/test_outer_join_with_null_value.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/query_p0/sql_functions/cast_function/test_nullable_functions.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/query_p0/sql_functions/array_functions/test_array_functions_by_literal.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/query_p0/sql_functions/json_functions/test_json_extract.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/query_p0/aggregate/map_agg_v1.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/dictionary_p0/test_dict_get_nullable.groovy`
- `./run-regression-test.sh --run -f
regression-test/suites/schema_change_p0/test_alter_table_column_nullable.groovy`
- Behavior changed: Yes, internal column nullability predicate now treats
const nullable as nullable; SQL behavior is intended to stay unchanged
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
