Copilot commented on code in PR #64410:
URL: https://github.com/apache/doris/pull/64410#discussion_r3394260868
##########
be/src/storage/segment/segment.h:
##########
@@ -260,6 +260,9 @@ class Segment : public
std::enable_shared_from_this<Segment>, public MetadataAdd
io::FileSystemSPtr _fs;
io::FileReaderSPtr _file_reader;
+ // Relative path passed to `open`, used to derive the inverted index path
(see
+ // _open_index_file_reader).
+ std::string _seg_path;
Review Comment:
The comment says `_seg_path` is a "Relative path", but in non-cloud/local
code paths `Segment::open()` is frequently called with an absolute local path.
This is misleading documentation for a new member that will be referenced in
future fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
