github-actions[bot] commented on code in PR #64395:
URL: https://github.com/apache/doris/pull/64395#discussion_r3394586697
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CopyIntoInfo.java:
##########
@@ -234,8 +241,10 @@ public void doValidate(String user, String db, boolean
checkAuth) throws Analysi
}
Review Comment:
This still does not create any synthetic file slots for the PR’s stated
`COPY INTO ... FROM (SELECT $1, ...)` path. In `CopyFromDesc.validate()`, the
`exprList != null` path calls `getFileColumnNames()`, but that method currently
builds an empty `slotRefs` list because the old legacy `Expr.collectList` call
is commented out; it then returns `true`, skips the `$1..$N` generation block,
and leaves `copyFromDesc.getFileColumns()` empty. With an empty `fileColumns`
list, `CopyIntoFileSlots` adds nothing to the scope here, so
`analyzer.analyze()` still binds only target-table slots and throws unknown
column `$1` for the stated repro. Please either populate `fileColumns` from the
Nereids `UnboundSlot`s in `CopyFromDesc`, or derive the placeholders for this
helper directly from `columnMappingList`/`fileFilterExpr`, and add a regression
covering `SELECT $1, ...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
