github-actions[bot] commented on code in PR #64133:
URL: https://github.com/apache/doris/pull/64133#discussion_r3395937520
##########
gensrc/proto/internal_service.proto:
##########
@@ -205,6 +205,9 @@ message PTabletWriterAddBlockRequest {
optional bool is_single_tablet_block = 14 [default = false];
// for auto-partition first stage close, we should hang.
optional bool hang_wait = 15 [default = false];
+ // Per-row row-binlog LSNs allocated by olap table sink. The order is the
same
+ // as rows in block/tablet_ids.
+ repeated int64 row_binlog_lsns = 16;
Review Comment:
This field needs a mixed-version compatibility path. During a rolling
upgrade, a new sink sends `row_binlog_lsns` but an old destination BE will
ignore unknown field 16 and still allocate row-binlog LSNs locally, so replicas
hosted on old and new BEs can still persist different LSNs for the same row.
The reverse direction also breaks: an old sink sends no field 16 to a new
destination BE, and the new receiver now treats that as `row binlog lsn is
missing` in `MemTableWriter::write()`, failing row-binlog loads. Please gate
the new behavior on a BE/protocol capability or keep a receiver fallback until
all senders are guaranteed to populate this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
