github-actions[bot] commented on code in PR #64412:
URL: https://github.com/apache/doris/pull/64412#discussion_r3400356805
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVRelation.java:
##########
@@ -80,6 +83,14 @@ public Set<BaseTableInfo> getBaseViews() {
return baseViews;
}
+ @Override
Review Comment:
Please add a test for this exact compatibility path. The existing
MTMVRelationTest creates a fresh MTMV, so baseViewsOneLevel is already
populated and that test would have passed before this PR. The reported failure
only happens after Gson deserializes old MTMV metadata where the bvol field is
absent; a focused test should deserialize such JSON through GsonUtils.GSON and
assert getBaseViewsOneLevel() is non-null before MetadataGenerator streams it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
