github-actions[bot] commented on code in PR #63832:
URL: https://github.com/apache/doris/pull/63832#discussion_r3401480907
##########
be/src/cloud/cloud_internal_service.cpp:
##########
@@ -581,8 +693,15 @@ void
CloudInternalServiceImpl::warm_up_rowset(google::protobuf::RpcController* c
if (!tablet->add_rowset_warmup_state(rs_meta,
WarmUpTriggerSource::EVENT_DRIVEN)) {
LOG(INFO) << "found duplicate warmup task for rowset " <<
rowset_id.to_string()
<< ", skip it";
+
g_warmup_ed_downstream_progress_tracker.record_task_done(job_id_str,
+
upstream_trigger_ts_ms);
+ record_warmup_ed_skipped_rowset_as_finished(rs_meta, job_id_str);
Review Comment:
`add_rowset_warmup_state` returns false both when the rowset is already
`DONE` and when an `EVENT_DRIVEN` warmup is still `DOING`. This branch treats
both cases as finished by advancing downstream progress and recording all
skipped files as finished, but the in-flight case is now reachable when two
table-level jobs have overlapping filters, or when the same rowset request is
retried while the first download is still running. In that case `SHOW WARM UP
JOB`/FE metrics can report zero trigger gap and full destination size even
though the original downloads may still be pending or may later fail. Please
only mark the duplicate request as finished when the existing warmup state is
already complete, or attach the duplicate job/progress accounting to the
in-flight completion instead of completing it immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
