github-actions[bot] commented on code in PR #64423:
URL: https://github.com/apache/doris/pull/64423#discussion_r3402083634
##########
fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java:
##########
@@ -770,6 +793,22 @@ public void clearRunningStreamTask(JobStatus newJobStatus)
{
}
}
+ // Command entry for a manual status change: reset the failure/retry
budget, and on manual pause
+ // release the reader (keep slot). "Manual" is decided by the caller,
never by reading failureReason.
+ public void onManualStatusAltered(JobStatus newStatus, FailureReason
reason) {
Review Comment:
Manual STOP still leaves the reused binlog reader alive. `ALTER JOB ...
STOPPED` goes through `updateJobStatus(STOPPED)`, which only calls
`cancelAllTasks()`; `StreamingMultiTblTask.cancel()` does not release, and this
new hook only releases on PAUSED. Before this PR the cdc_client finally path
closed binlog readers at task end, but now `cleanupReaderResources()` keeps
them for reuse, so a stopped job can continue holding the PG slot/MySQL reader
until the idle reaper happens to release it. Please release or close the
running remote reader on STOP as well instead of relying on DROP `/api/close`
or the idle timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
