yx-keith opened a new pull request, #64478:
URL: https://github.com/apache/doris/pull/64478
Move the synchronized modifier from the public addTablet / appendTablets
methods onto appendTabletsInternal, the only block that actually mutates the
per-index list and idToTablets map.
The TabletInvertedIndex.addTablet(...) call in the non-restore path of
addTablet does not need to share this lock — it has its own internal
synchronization and operates on a separate object. Holding the per-index
monitor across that call only serialized unrelated writers without guarding any
shared state on this index.
Readers see the new tablets via the same volatile publish in
appendTabletsInternal as before, so the existing TOCTOU window between the
per-index snapshot and TabletInvertedIndex (handled by the
IllegalStateException catch in TabletStatMgr.updateTabletStat) is unchanged in
both width and shape.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
