github-actions[bot] commented on code in PR #64262:
URL: https://github.com/apache/doris/pull/64262#discussion_r3407558433
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -2832,6 +2832,20 @@ public Boolean storeRowColumn() {
return false;
}
+ public void setRowStoreOnly(boolean rowStoreOnly) {
Review Comment:
Persisting the flag in `TableProperty` is not enough for DDL round trips:
`Env.getDdlStmt` only emits
`row_store_columns`/`store_row_column`/`row_store_page_size` for row-store
tables and never emits `row_store_only`. A `SHOW CREATE TABLE` (and tools that
replay that SQL) for a row-store-only table will recreate it as a regular
row-store table. Please include `row_store_only=true` in the generated table
properties when this flag is set, and add a test for that round trip.
##########
regression-test/suites/row_store/test_row_store_only.groovy:
##########
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_row_store_only", "p0, nonConcurrent") {
+ sql "DROP TABLE IF EXISTS test_row_store_only FORCE"
+ sql "DROP TABLE IF EXISTS test_row_store_only_with_subset FORCE"
+
+ test {
+ sql """
+ CREATE TABLE test_row_store_only_with_subset (
+ k INT NOT NULL,
+ v1 INT,
+ v2 VARCHAR(20)
+ ) UNIQUE KEY(k)
+ DISTRIBUTED BY HASH(k) BUCKETS 1
+ PROPERTIES (
+ "replication_num" = "1",
+ "enable_unique_key_merge_on_write" = "true",
+ "light_schema_change" = "true",
+ "store_row_column" = "true",
+ "row_store_only" = "true",
+ "row_store_columns" = "k,v1"
+ )
+ """
+ exception "row_store_columns must be empty when row_store_only is true"
+ }
+
+ sql """
+ CREATE TABLE test_row_store_only (
+ k INT NOT NULL,
+ v1 INT DEFAULT "0",
+ v2 VARCHAR(20) DEFAULT "x",
+ v3 INT DEFAULT "7"
+ ) UNIQUE KEY(k)
+ DISTRIBUTED BY HASH(k) BUCKETS 1
+ PROPERTIES (
+ "replication_num" = "1",
+ "enable_unique_key_merge_on_write" = "true",
+ "light_schema_change" = "true",
+ "disable_auto_compaction" = "true",
+ "store_row_column" = "true",
+ "row_store_only" = "true"
+ )
+ """
+
+ sql """ INSERT INTO test_row_store_only VALUES (1, 10, 'a', 100), (2, 20,
'b', 200), (3, 30, 'c', 300) """
+ sql "sync"
+ order_qt_initial """ SELECT * FROM test_row_store_only ORDER BY k """
Review Comment:
This new suite uses `order_qt_`/`qt_` checks, but the PR does not add
`regression-test/data/row_store/test_row_store_only.out`. In normal regression
check mode `quickTest` requires the suite output file to exist and will fail
with `Missing outputFile` before validating these queries. Please run the suite
with output generation and commit the generated `.out` file so this coverage is
executable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
