heguanhui commented on code in PR #64484:
URL: https://github.com/apache/doris/pull/64484#discussion_r3410960232
##########
be/src/storage/segment/row_binlog_segment_writer.cpp:
##########
@@ -331,8 +331,13 @@ Status RowBinlogSegmentWriter::_fill_binlog_columns(size_t
num_rows,
// (SegmentIterator::_update_tso_col_if_needed), so its on-disk value
is never used.
// Write a NULL placeholder.
IColumn* ts_col_ptr = binlog_prefix_columns[2].get();
- auto* ts_nullable_column = assert_cast<ColumnNullable*>(ts_col_ptr);
- ts_nullable_column->insert_many_defaults(num_rows); // NULL
placeholder (value + null map)
+ auto* ts_nullable_column =
check_and_get_column<ColumnNullable>(ts_col_ptr);
Review Comment:
> not necessary, for row binlog writer ts_col_ptr should always exist
this fixed in pr [#64495](https://github.com/apache/doris/pull/64495)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
