github-actions[bot] commented on code in PR #64071: URL: https://github.com/apache/doris/pull/64071#discussion_r3412301296
########## fe/fe-core/src/test/java/org/apache/doris/nereids/load/NereidsRoutineLoadTaskInfoTest.java: ########## @@ -0,0 +1,61 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.load; + +import org.apache.doris.datasource.property.fileformat.JsonFileFormatProperties; +import org.apache.doris.load.loadv2.LoadTask; +import org.apache.doris.thrift.TPartialUpdateNewRowPolicy; + +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +import java.util.HashMap; +import java.util.Map; + +public class NereidsRoutineLoadTaskInfoTest { + + private NereidsRoutineLoadTaskInfo buildTaskInfo(Map<String, String> jobProperties) { + return new NereidsRoutineLoadTaskInfo(0L, jobProperties, 10L, null, + LoadTask.MergeType.APPEND, null, null, 0.0, + new NereidsLoadTaskInfo.NereidsImportColumnDescs(), null, null, null, + null, (byte) 0, (byte) 0, 1, false, false, Review Comment: This helper no longer matches the `NereidsRoutineLoadTaskInfo` constructor. The argument after `loadToSingleTablet` is `TUniqueKeyUpdateMode`, but this passes a second `false`, so FE test compilation fails before these tests can run. Pass a concrete mode (for example `TUniqueKeyUpdateMode.UPSERT`). ```suggestion null, (byte) 0, (byte) 0, 1, false, org.apache.doris.thrift.TUniqueKeyUpdateMode.UPSERT, ``` ########## fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/AlterRoutineLoadCommandTest.java: ########## @@ -114,5 +116,34 @@ public void testValidate() { Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(CreateRoutineLoadInfo.MAX_BATCH_SIZE_PROPERTY)); Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(CreateRoutineLoadInfo.STRICT_MODE)); Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(CreateRoutineLoadInfo.TIMEZONE)); + Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(JsonFileFormatProperties.PROP_FILL_MISSING_COLUMNS)); Review Comment: `git diff --check` reports trailing whitespace on this blank line, and the same pattern appears again before the next test. FE checkstyle has a `Trailing whitespace found` rule, so style validation will still fail after the compile error is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
