heguanhui commented on code in PR #64484:
URL: https://github.com/apache/doris/pull/64484#discussion_r3414443443
##########
be/src/storage/tablet/tablet_meta.cpp:
##########
@@ -525,6 +527,11 @@ void TabletMeta::init_schema_from_thrift(const
TTabletSchema& tablet_schema,
}
col_ordinal++;
init_column_from_tcolumn(unique_id, tcolumn, column);
+ if (tcolumn.column_name == BINLOG_LSN_COL) {
Review Comment:
You're right. I'll combine both fixes into this PR:
1. Fix binlog column index in init_schema_from_thrift
2. Fix test helper to set nullable for binlog special columns
This way the UT will pass without modifying row_binlog_segment_writer.cpp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
