morrySnow commented on code in PR #64458: URL: https://github.com/apache/doris/pull/64458#discussion_r3418632879
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/NormalizeAggregate.java: ########## @@ -19,6 +19,7 @@ Review Comment: Nit: could you add a unit test for the global-aggregate case (no GROUP BY) with a constant non-aggregated column, e.g. `SELECT a, COUNT(*) FROM (SELECT 1 AS a) t`? MySQL rejects this under `only_full_group_by`, and the `!normalizedGroupExprs.isEmpty()` guard correctly preserves that rejection. A test would protect against future refactoring accidentally removing the guard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
