morrySnow commented on code in PR #63690:
URL: https://github.com/apache/doris/pull/63690#discussion_r3418752351
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -680,16 +678,12 @@ public class Rewriter extends AbstractBatchJobExecutor {
topDown(new PushDownAggThroughJoinOnPkFk()),
topDown(new PullUpJoinFromUnionAll())
),
+ topic("init join", bottomUp(ImmutableList.of(new
InitJoinOrder()))),
topic("Eager aggregation",
cascadesContext ->
cascadesContext.rewritePlanContainsTypes(
LogicalAggregate.class, LogicalJoin.class
),
- costBased(topDown(
- new
PushDownAggWithDistinctThroughJoinOneSide(),
- new PushDownAggThroughJoinOneSide()
- )),
-
-
costBased(custom(RuleType.PUSH_DOWN_DISTINCT_THROUGH_JOIN,
PushDownDistinctThroughJoin::new)),
+ costBased(topDown(new
PushDownAggWithDistinctThroughJoinOneSide())),
Review Comment:
wrong suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
