HappenLee commented on code in PR #64165:
URL: https://github.com/apache/doris/pull/64165#discussion_r3447891526
##########
be/src/exec/runtime_filter/runtime_filter_consumer.cpp:
##########
@@ -237,4 +238,16 @@ void
RuntimeFilterConsumer::collect_realtime_profile(RuntimeProfile* parent_oper
c->update(_always_true_counter->value());
}
+void RuntimeFilterConsumer::collect_scan_filter_profile(ScanFilterProfile*
scan_filter_profile) {
+ std::unique_lock<std::recursive_mutex> l(_rmtx);
+ DCHECK(scan_filter_profile != nullptr);
+ scan_filter_profile->set_runtime_filter_profile_stats(
+ {.runtime_filter_id = _wrapper->filter_id(),
+ .input_rows = _rf_input->value(),
+ .filtered_rows = _rf_filter->value(),
+ .wait_time_ns = _wait_timer->value(),
+ .always_true_filter_rows = _always_true_counter->value(),
+ .debug_string = debug_string()});
Review Comment:
可以添加一个_debug_string_internal()的方法，不获取锁，这样可以不引入递归锁，
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
