Copilot commented on code in PR #64664:
URL: https://github.com/apache/doris/pull/64664#discussion_r3449789796
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -6455,6 +6456,14 @@ public void checkDefaultVariantMaxSubcolumnsCount(String
variantMaxSubcolumnsCou
}
}
+ public void checkDefaultVariantMaxSparseColumnStatisticsSize(String
variantMaxSparseColumnStatisticsSize) {
+ int value = Integer.valueOf(variantMaxSparseColumnStatisticsSize);
+ if (value < 1 || value > 50000) {
+ throw new UnsupportedOperationException("variant max sparse column
statistics size is: "
+ + variantMaxSparseColumnStatisticsSize + " it must between
1 and 50000");
+ }
Review Comment:
The new session-variable checker error message is grammatically unclear ("it
must between") and misses a comma separator, which makes debugging harder.
Consider rephrasing to "it must be between ..." while keeping the existing
substring used by regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
