Mryange opened a new pull request, #64694:
URL: https://github.com/apache/doris/pull/64694
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
This is a staged change to make existing column and Arrow data validity
checks available outside debug-only paths while keeping them disabled by
default.
Root cause: ColumnString::sanity_check() was guarded by NDEBUG, so release
builds could not enable the existing offset and chars consistency checks. Arrow
conversion paths also accepted invalid Arrow arrays without a shared validation
gate, and nested Arrow serde reads would repeat validation if validation were
placed directly in every nested call.
This change adds two opt-in BE configs:
- enable_column_sanity_check: enables column sanity checks in release builds.
- enable_arrow_validate_full: enables Arrow ValidateFull() checks on Arrow
read/write conversion paths.
The column path keeps the existing sanity_check() API name and semantics.
Debug builds still run ColumnString sanity checks as before, while release
builds return early unless enable_column_sanity_check is enabled. Expression
evaluation calls sanity_check() after producing result columns when the config
is enabled.
The Arrow read path now uses a non-virtual
DataTypeSerDe::read_column_from_arrow() wrapper to run ValidateFull() once at
the top-level entry, then delegates to read_column_from_arrow_impl(). Nested
array/map/nullable/struct serde reads call the impl method directly to avoid
repeated validation. The Arrow write path validates finished arrays and the
final record batch when enable_arrow_validate_full is enabled, without adding
another serde write implementation layer.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
