Copilot commented on code in PR #64733:
URL: https://github.com/apache/doris/pull/64733#discussion_r3458333167
##########
regression-test/suites/export_p2/test_export_variant_10k_columns.groovy:
##########
Review Comment:
This mixes `println` with `logger.info`, and the RuntimeException message
concatenation is missing a separating space, making logs harder to read. Prefer
using the logger consistently here and format the exception message clearly
(e.g., include a separator and/or the load label/state).
##########
regression-test/suites/export_p2/test_export_variant_10k_columns.groovy:
##########
@@ -189,7 +190,7 @@ suite("test_export_variant_10k_columns", "p0") {
);
"""
- Awaitility.await().atMost(240, SECONDS).pollInterval(5,
SECONDS).until({
+ Awaitility.await().atMost(20, MINUTES).pollInterval(5, SECONDS).until({
Review Comment:
With a 5-second poll interval and a 20-minute timeout, this will emit up to
~240 info logs per run. To reduce log noise, consider logging only when the
state changes, or lowering verbosity / increasing the poll interval while
keeping the same `atMost`.
##########
regression-test/suites/export_p2/test_export_variant_10k_columns.groovy:
##########
Review Comment:
With a 5-second poll interval and a 20-minute timeout, this will emit up to
~240 info logs per run. To reduce log noise, consider logging only when the
state changes, or lowering verbosity / increasing the poll interval while
keeping the same `atMost`.
##########
regression-test/suites/export_p2/test_export_variant_10k_columns.groovy:
##########
@@ -189,7 +190,7 @@ suite("test_export_variant_10k_columns", "p0") {
);
"""
- Awaitility.await().atMost(240, SECONDS).pollInterval(5,
SECONDS).until({
+ Awaitility.await().atMost(20, MINUTES).pollInterval(5, SECONDS).until({
Review Comment:
The new 20-minute timeout is hard-coded, which can make CI slower to fail
when a load is genuinely stuck. Consider making the timeout configurable (e.g.,
via a system property / env var with a sensible default), so CloudP0 can use 20
minutes while other environments keep a shorter limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
