morningman commented on code in PR #15509:
URL: https://github.com/apache/doris/pull/15509#discussion_r1060025932
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java:
##########
@@ -92,7 +101,9 @@ public static PartitionKey
createListPartitionKeyWithTypes(List<PartitionValue>
// PARTITION BY LIST(k1, k2)
// (
// PARTITION p1 VALUES IN (("1","beijing"), ("1", "shanghai")),
- // PARTITION p2 VALUES IN (("2","shanghai"))
+ // PARTITION p2 VALUES IN (("2","shanghai")),
+ // PARTITION p3 VALUES IN,
+ // PARTITION p4,
Review Comment:
```suggestion
// PARTITION p4 DEFAULT,
```
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -3043,7 +3048,13 @@ partition_key_desc ::=
/* list partition PartitionKeyDesc */
list_partition_key_desc ::=
- LPAREN list_partition_values_list:keys RPAREN
+ /* empty */
Review Comment:
How about adding `DEFAULT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
