github-actions[bot] commented on code in PR #64723:
URL: https://github.com/apache/doris/pull/64723#discussion_r3467246592
##########
regression-test/suites/external_table_p0/hive/ddl/test_hive_ddl.groovy:
##########
@@ -399,6 +399,12 @@ suite("test_hive_ddl", "p0,external") {
throw new Exception("Invalid compression type: ${compression}
for tbl_${file_format}_${compression}")
}
+ if (compression.equals("lz4")) {
+ sql """ INSERT INTO tbl_${file_format}_${compression} VALUES
('doris_lz4') """
+ def q_lz4 = "order_qt_hive_${file_format}_${compression}_write"
+ "${q_lz4}" """ SELECT * FROM tbl_${file_format}_${compression}
ORDER BY col """
Review Comment:
The Hive Parquet LZ4 branch still only proves that Doris can read the row
back. That does not protect the compatibility fix here, because
`VHivePartitionWriter` now deliberately maps `LZ4BLOCK` to
`TParquetCompressionType::LZ4_HADOOP`, while the Parquet helper still has the
separate raw `TParquetCompressionType::LZ4` path, and Doris can read both
variants. Please add a Hive Parquet metadata assertion similar to the Iceberg
one, using the generated Hive file path with `parquet_meta(..., mode =
"parquet_metadata")` and expecting footer `compression = LZ4`, so a regression
back to `LZ4_RAW` is caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
