github-actions[bot] commented on code in PR #64857:
URL: https://github.com/apache/doris/pull/64857#discussion_r3474086199
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/ProgressManager.java:
##########
@@ -56,7 +56,8 @@ public void updateProgress(String id, TUniqueId queryId,
TUniqueId fragmentId, i
if (progress != null) {
progress.updateFinishedScanNums(queryId, fragmentId,
finishedScannerNum);
} else {
- LOG.warn("progress[" + id + "] missing meta information");
+ LOG.warn("progress id {} missing meta information, queryId {},
fragmentId {}",
Review Comment:
This warning should format the thrift IDs with `DebugUtil.printId(...)`
before logging them. The callers pass `TUniqueId` objects from the report
status path, but the surrounding FE diagnostics use the canonical hex `hi-lo`
string for query and instance ids, e.g. `LoadProcessor` logs
`DebugUtil.printId(params.getQueryId())`, `Coordinator` logs fragment instances
with `DebugUtil.printId(params.getFragmentInstanceId())`, and
`DebugUtil.parseTUniqueIdFromString` documents that query-id strings are
generated by `DebugUtil.printId(TUniqueId)`. Logging the raw thrift object here
produces a different shape, so the added warning still will not line up cleanly
with existing query/profile ids. Please log `DebugUtil.printId(queryId)` and
`DebugUtil.printId(fragmentId)` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
