github-actions[bot] commented on code in PR #64863: URL: https://github.com/apache/doris/pull/64863#discussion_r3474627596
########## tools/tpch-tools/constraints/drop-pk-uk-constraints.sql: ########## @@ -0,0 +1,11 @@ +-- Drop all TPC-H Primary Key and Unique Key Constraints +alter table region drop r_pk; Review Comment: This cleanup script needs to use the constraint-drop form, e.g. `alter table region drop constraint r_pk;`, for all of these entries. Doris' constraint grammar only maps `ALTER TABLE ... DROP CONSTRAINT <name>` to `DropConstraintCommand` (`DorisParser.g4` has `DROP CONSTRAINT constraintName`), and the FK cleanup script in this PR already uses that form. As written, running this file will not remove the PK/UK constraints that `tpch-fd.sql` adds, leaving the metadata in place for later plans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
