bobhan1 opened a new pull request, #64884:
URL: https://github.com/apache/doris/pull/64884

   ### What problem does this PR solve?
   
   Issue Number: N/A
   
   Related PR: N/A
   
   Problem Summary: DELETE on a unique merge-on-write table with light delete 
disabled is rewritten to a partial update load that writes key columns and the 
delete sign. BindSink used to auto-add every generated column and then 
recompute omitted value generated columns, which required ordinary value 
columns that were not part of the DELETE output and caused analysis to fail.
   
   This change treats DELETE partial updates specially: generated columns that 
are not emitted by the child plan are skipped, and generated columns that are 
emitted by the child plan use that child output directly. Normal partial update 
generated-column dependency checks are unchanged.
   
   ### Release note
   
   Fix DELETE failure on unique merge-on-write tables with generated columns 
when light delete is disabled.
   
   ### Check List (For Author)
   
   - Test: Regression test
       - `./build.sh --fe -j100`
       - `./run-regression-test.sh --run -d 
regression-test/suites/ddl_p0/test_create_table_generated_column -s 
test_generated_column_delete -forceGenOut`
       - `./run-regression-test.sh --run -d 
regression-test/suites/ddl_p0/test_create_table_generated_column -s 
test_generated_column_delete`
       - `./run-regression-test.sh --run -d 
regression-test/suites/ddl_p0/test_create_table_generated_column -s 
test_partial_update_generated_column`
   - Behavior changed: Yes (DELETE now succeeds for unique merge-on-write 
tables with generated columns when light delete is disabled.)
   - Does this need documentation: No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to