Mryange opened a new pull request, #64905:
URL: https://github.com/apache/doris/pull/64905
### What problem does this PR solve?
Column wrappers used `for_each_subcolumn` for both read-only traversal and
mutable subcolumn detachment during COW mutation. This mixed two different
contracts in one callback API and forced typed subcolumns such as
`ColumnNullable::_null_map`, `ColumnArray::offsets`, and
`ColumnMap::offsets_column` to move through temporary base
`IColumn::WrappedPtr` bridges.
Root cause: the mutable callback accepted `IColumn::WrappedPtr&`, but
several subcolumns are stored as strongly typed wrappers. Binding typed wrapper
references to the base wrapper callback is unsafe, so each implementation
needed ad-hoc move/defer/cast code.
This PR keeps `for_each_subcolumn` as a const read-only traversal API and
adds `mutate_subcolumns()` for the COW mutation path. Common `mutate_subcolumn`
helpers handle generic and strongly typed subcolumns, so `ColumnArray`,
`ColumnMap`, `ColumnNullable`, `ColumnStruct`, and `ColumnVariant` can detach
children without exposing a mutable traversal callback. The added BEUT cases
also verify that mutating exclusive subcolumns does not introduce an extra copy.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
