feiniaofeiafei opened a new pull request, #65005:
URL: https://github.com/apache/doris/pull/65005
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: None
Problem Summary:
When eager aggregation pushes aggregate operations below both sides of a
Join, the rewritten Join must be processed by `buildCanonicalJoinProject`.
Previously, this method was invoked only when either child produced a count
slot. For aggregates such as `MAX`, no count slot is required. As a result,
bilateral pushdown could return the rewritten Join directly without
constructing the canonical Join Project.
The missing Project meant that the pushed aggregate output was not
registered in `BilateralState#idToPushedSlot`. Subsequent rewrites retrieved a
null slot from this map and triggered a `NullPointerException`.
This change invokes `buildCanonicalJoinProject` whenever aggregation is
pushed to both Join children, even when neither side produces a count slot. It
ensures that pushed aggregate outputs are correctly projected and registered.
A regression case covering bilateral `MAX` pushdown through a RIGHT JOIN is
also added.
### Release note
Fix a NullPointerException when eager aggregation pushes MAX below both
sides of a Join.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
