github-actions[bot] commented on code in PR #59263:
URL: https://github.com/apache/doris/pull/59263#discussion_r3503219705
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -2811,10 +2870,43 @@ Status
SegmentIterator::_read_columns_by_rowids(std::vector<ColumnId>& read_colu
"SegmentIterator meet invalid column, return columns size
{}, cid {}",
_current_return_columns.size(), cid);
}
- RETURN_IF_ERROR(_column_iterators[cid]->read_by_rowids(rowids.data(),
select_size,
-
_current_return_columns[cid]));
+
+ auto* column_iter = _column_iterators[cid].get();
+ ScopedColumnIteratorReadPhase scoped_read_phase {
+ column_iter, read_for_predicate &&
_support_lazy_read_pruned_columns.contains(cid)
+ ? ColumnIterator::ReadPhase::PREDICATE
+ : ColumnIterator::ReadPhase::NORMAL};
+
+ RETURN_IF_ERROR(column_iter->read_by_rowids(rowids.data(), select_size,
+
_current_return_columns[cid]));
+ }
+
+ return Status::OK();
+}
+
+Status SegmentIterator::_read_lazy_pruned_columns(Block* block) {
+ if (_support_lazy_read_pruned_columns.empty()) {
+ return Status::OK();
}
+ SCOPED_RAW_TIMER(&_opts.stats->lazy_read_pruned_ns);
+ DorisVector<rowid_t> rowids(_selected_size);
Review Comment:
_read_lazy_pruned_columns() now declares `DorisVector<rowid_t>`, but this
translation unit never includes `core/custom_allocator.h`, which is where
`DorisVector` is declared. The current direct include set does not provide that
alias, so compiling `segment_iterator.cpp` can fail with an unknown
`DorisVector`. Please add the missing `#include "core/custom_allocator.h"` near
the other `core/` includes, or use a container whose declaration is already
available here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
