github-actions[bot] commented on code in PR #65099:
URL: https://github.com/apache/doris/pull/65099#discussion_r3504718179
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java:
##########
@@ -240,7 +240,6 @@ public enum RuleType {
ELIMINATE_SORT(RuleTypeClass.REWRITE),
PUSH_DOWN_AGG_THROUGH_JOIN_ONE_SIDE(RuleTypeClass.REWRITE),
- PUSH_DOWN_AGG_WITH_DISTINCT_THROUGH_JOIN_ONE_SIDE(RuleTypeClass.REWRITE),
Review Comment:
Removing this enum makes existing rule-control settings fail during parsing.
`disable_nereids_rules` is a forwarded session variable, and
`SessionVariable#getDisableNereidsRules()` still calls
`RuleType.valueOf(ruleName)` for every configured name, so a deployment or
query hint that currently has
`PUSH_DOWN_AGG_WITH_DISTINCT_THROUGH_JOIN_ONE_SIDE` saved will now throw
`IllegalArgumentException` instead of just disabling a now-removed
implementation. Since this rule name was user-addressable through
`disable_nereids_rules`/CBO rule hints, please keep the enum value as a no-op
compatibility alias, or add explicit migration handling for the old name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
