nishant94 commented on PR #64667: URL: https://github.com/apache/doris/pull/64667#issuecomment-4863352039
> [Non-blocking] Viterbi hot path allocates per byte position; +16% measured with a small change @Ryan19929 I am glad to see you spent time for benchmarking analyzers. Love to see these benchmarks. Also your optimization suggestion is pretty helpful. I took the refernce from it and swapped the ending_at vector-of-vectors for the intrusive `end_head`/`end_next` chain, and hoisted matches out of the per-position loop so `common_prefix_search()` reuses one buffer. Thank you Ryan !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
