TsukiokaKogane commented on code in PR #64776:
URL: https://github.com/apache/doris/pull/64776#discussion_r3517981174


##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java:
##########
@@ -193,6 +194,7 @@ public boolean isWarmup() {
             PLAN_TIME,
             NEREIDS_GARBAGE_COLLECT_TIME,
             NEREIDS_PRELOAD_EXTERNAL_METADATA_TIME,
+            WAIT_CHANGE_VISIBLE_TIME,
             NEREIDS_LOCK_TABLE_TIME,

Review Comment:
   will fix it



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/NormalizeOlapTableStreamScan.java:
##########
@@ -63,44 +73,274 @@
  * 2. add delete sign column if unique base table
  */
 public class NormalizeOlapTableStreamScan extends OneRewriteRuleFactory {
-    private static final long ROW_BINLOG_APPEND = 0;
-    private static final long ROW_BINLOG_DELETE = 1;
-    private static final long ROW_BINLOG_UPDATE_BEFORE = 2;
-    private static final long ROW_BINLOG_UPDATE_AFTER = 3;
-
     @Override
     public Rule build() {
         return logicalOlapTableStreamScan()
-                .when(scan -> !scan.isNormalized())
-                .then(this::normalize)
+                .thenApply(ctx -> normalize(ctx.root, ctx.cascadesContext))
                 .toRule(RuleType.NORMALIZE_OlAP_TABLE_STREAM_SCAN);

Review Comment:
   ignore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to