github-actions[bot] commented on code in PR #64071:
URL: https://github.com/apache/doris/pull/64071#discussion_r3523374122
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateRoutineLoadInfo.java:
##########
@@ -130,6 +130,7 @@ public class CreateRoutineLoadInfo {
.add(JsonFileFormatProperties.PROP_STRIP_OUTER_ARRAY)
.add(JsonFileFormatProperties.PROP_NUM_AS_STRING)
.add(JsonFileFormatProperties.PROP_FUZZY_PARSE)
+ .add(JsonFileFormatProperties.PROP_FILL_MISSING_COLUMNS)
Review Comment:
This whitelist makes `fill_missing_columns` look valid before the create
path knows the file format. If the user omits `format` or sets `format=csv`,
`checkJobProperties()` defaults to CSV and dispatches to
`CsvFileFormatProperties`, which never consumes or validates this JSON-only
boolean. A create statement like `PROPERTIES("fill_missing_columns" = "treu")`
therefore passes and silently ignores the typo, while `ALTER ROUTINE LOAD` and
the JSON parser now reject the same value. Please validate this key before
format dispatch, or reject it for non-JSON formats, and add a create-path
negative test for the default/CSV case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
