starocean999 opened a new pull request, #65219: URL: https://github.com/apache/doris/pull/65219
Related PR: https://github.com/apache/doris/pull/64795 Problem Summary: When a table has a `TIMESTAMPTZ` partition column and `dynamic_partition.time_zone` is set to a non-UTC timezone (e.g., `Asia/Shanghai`), the dynamically created partition boundaries are shifted to midnight in the configured timezone rather than UTC midnight. **Root cause:** `getAddPartitionOp()` computed the current date (`now`) in the configured timezone, then `convertToUtcTimestamp()` interpreted the resulting date string as midnight in that timezone and converted it to UTC — producing a timezone-offset hour (e.g., 16:00) instead of UTC midnight (00:00). Both the `now` computation and the timezone used in `convertToUtcTimestamp()` needed to be fixed. ### Fix In `DynamicPartitionScheduler.getAddPartitionOp()`, decouple the time references for boundary computation and naming: 1. **Boundary computation**: For `TIMESTAMPTZ`, use `ZonedDateTime.now(UTC)` for the current clock and pass UTC as the source timezone to `convertToUtcTimestamp()`. This ensures partition boundaries are at UTC midnight (00:00–24:00) regardless of `dynamic_partition.time_zone`. 2. **Partition naming**: Keep using `ZonedDateTime.now(configured_timezone)` for generating `prevBorderForName`, so partition names remain identical to the pre-fix behavior. The `dynamic_partition.time_zone` property continues to control naming (e.g., week-of-year computation for week partitions). 3. **Storage properties**: `setStorageMediumProperty()` and `setStoragePolicyProperty()` also use the configured-timezone `nowTz` so hot partition determination stays consistent with naming. ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
