morrySnow commented on code in PR #65247:
URL: https://github.com/apache/doris/pull/65247#discussion_r3527010656
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java:
##########
@@ -872,6 +876,28 @@ public static Slot checkTargetChild(Expression leftChild) {
return expression instanceof Slot ? ((Slot) expression) : null;
}
+ @VisibleForTesting
+ public static boolean canPushDownRuntimeFiltersIntoCTEProducer(
+ List<RuntimeFilter> rfsToPushDown, CTEId cteId) {
+ Preconditions.checkArgument(!rfsToPushDown.isEmpty());
Review Comment:
do not check, return false and add a warning log instead
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java:
##########
@@ -895,16 +921,15 @@ private boolean
doPushDownIntoCTEProducerInternal(RuntimeFilter rf, Expression t
}
// Map consumer slot to producer slot
Slot producerSlot = cteConsumer.getProducerSlot(consumerSlot);
- if (producerSlot == null) {
- return false;
- }
+ Expression producerTargetExpression = getProducerTargetExpression(rf,
cteProducer.getCteId());
+
Preconditions.checkArgument(checkTargetChild(producerTargetExpression).equals(producerSlot));
Review Comment:
do not check, return false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
