feiniaofeiafei opened a new pull request, #65257:
URL: https://github.com/apache/doris/pull/65257
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Eager aggregation could reach a logical relation with no
aggregate functions or group keys and generate an invalid empty aggregate.
Return the relation unchanged for this empty push-down context and add a
focused unit test covering the visitor path.
### Release note
Prevent eager aggregation rewrite from generating an empty aggregate on a
relation.
### Check List (For Author)
- Test: Unit Test
- ./run-fe-ut.sh --run
org.apache.doris.nereids.rules.rewrite.eageraggregation.EagerAggRewriterTest
- ./run-fe-ut.sh --run
org.apache.doris.nereids.rules.rewrite.eageraggregation.EagerAggRewriterTest#testEmptyContextDoesNotAddRelationAggregate
- Behavior changed: Yes (empty eager-aggregation contexts now leave
relations unchanged)
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
