github-actions[bot] commented on code in PR #64038:
URL: https://github.com/apache/doris/pull/64038#discussion_r3531209721
##########
be/src/io/fs/azure_obj_storage_client.cpp:
##########
@@ -124,6 +125,7 @@ ObjectStorageResponse do_azure_client_call(Func f, const
ObjectStoragePathOption
try {
f();
Review Comment:
This only records direct Azure client failures that flow through
`do_azure_client_call()`, but BE batch deletes have another final-failure path
below in `AzureBatchDeleter::execute()`: each deferred `DeleteBlob` subresponse
calls `GetResponse()`, catches `Azure::Core::RequestFailedException`, and
returns the error without calling `record_object_request_failed()`. A 429 from
one of those batch subresponses will therefore still be missing from
`s3_request_failed_too_many_requests_count` even though the Cloud recycler
batch path now records it. Please add the same
`record_object_request_failed(static_cast<int>(e.StatusCode))` call in that
deferred-response catch after the NotFound exemption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
