JNSimba commented on code in PR #365:
URL:
https://github.com/apache/doris-spark-connector/pull/365#discussion_r3533214952
##########
tools/releasing/deploy_staging_jars.sh:
##########
@@ -61,5 +61,15 @@ ${MVN} clean deploy -Papache-release -DskipTests
-DretryFailedDeploymentCount=10
echo "Deploying spark3.5..."
${MVN} clean deploy -Papache-release -DskipTests
-DretryFailedDeploymentCount=10 -Pspark-3.5 -pl spark-doris-connector-spark-3.5
-am
+# Spark 4.x requires JDK 17 and Scala 2.13 (the modules above target JDK 8).
Set JAVA17_HOME to a
+# JDK 17 home to deploy them with the right toolchain; otherwise the current
JAVA_HOME must be JDK 17.
+SPARK4_MVN_ENV=""
+if [ -n "${JAVA17_HOME:-}" ]; then
+ SPARK4_MVN_ENV="JAVA_HOME=${JAVA17_HOME}"
+fi
Review Comment:
If JDK 17 is not detected here, the build falls back to JDK 8, which causes
the compilation to fail. Since this release script cannot be rerun after the
environment is corrected, I suggest splitting the JDK 8 and JDK 17 release
processes into separate scripts. This would allow the appropriate release
script to be rerun if a JDK switching issue occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
