feiniaofeiafei commented on code in PR #65172:
URL: https://github.com/apache/doris/pull/65172#discussion_r3533492806
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushDownAggThroughJoinOnPkFk.java:
##########
@@ -280,6 +280,7 @@ private LogicalAggregate<?>
eliminatePrimaryOutput(LogicalAggregate<?> agg, Plan
*/
static class InnerJoinCluster {
private final Map<BitSet, LogicalJoin<?, ?>> innerJoins = new
HashMap<>();
Review Comment:
```java
private final Map<BitSet, LogicalJoin<?, ?>> innerJoins = new HashMap<>();
```
This may lead to unstable join shape, use LinkedHashMap is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
