github-actions[bot] commented on code in PR #65332:
URL: https://github.com/apache/doris/pull/65332#discussion_r3536066774
##########
be/src/format/table/paimon_jni_reader.cpp:
##########
@@ -74,6 +79,21 @@ PaimonJniReader::PaimonJniReader(const
std::vector<SlotDescriptor*>& file_slot_d
params[PAIMON_OPTION_PREFIX + kv.first] =
kv.second;
}
}
+ const std::string enable_io_manager_key =
+ PAIMON_OPTION_PREFIX +
DORIS_ENABLE_JNI_IO_MANAGER;
+ const std::string io_manager_tmp_dir_key =
+ PAIMON_OPTION_PREFIX +
DORIS_JNI_IO_MANAGER_TMP_DIR;
+ auto enable_io_manager_it =
params.find(enable_io_manager_key);
+ if (enable_io_manager_it != params.end() &&
Review Comment:
This fallback also needs to be applied on the FileScannerV2 Paimon JNI path.
`enable_file_scanner_v2` defaults to true, and
`FileScannerV2::is_supported_jni_table_format` accepts Paimon JNI ranges, so
normal query scans can instantiate
`format::paimon::PaimonHybridReader`/`format_v2/jni/PaimonJniReader` instead of
this legacy reader. That V2 `build_scanner_params()` only prefixes the
scan-level `paimon_options`; with a catalog that sets only
`paimon.doris.enable_jni_io_manager=true`, no tmp-dir option is present, and
`PaimonJniScanner.getIOManagerTempDirs()` throws before the reader opens.
Please share this BE tmp-dir default with the V2 reader as well, and add
coverage with scanner v2 enabled for the enable-only catalog property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
